From 4994d33fd5f4f5c7dcc8f89c9b6de6be50e0c407 Mon Sep 17 00:00:00 2001
From: NixReaper <nixreaper@outlook.com>
Date: Sat, 25 Apr 2026 08:54:20 -0500
Subject: [PATCH] =?UTF-8?q?ci:=20fix=20security=20workflow=20=E2=80=94=20d?=
 =?UTF-8?q?rop=20CodeQL,=20fix=20ShellCheck=20severity?=
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit

- Remove CodeQL job: this repo has no JS/TS or Rust source code,
  so CodeQL exits with error 32 ('no source code seen during build')
  on every run. CodeQL belongs on nixpanel-website/nixpanel-licensing.
- cargo-audit: skip Rust toolchain install entirely when no Cargo.toml
  present (saves ~3 min of wasted CI time); use step output condition
- ShellCheck: severity error->only fails on real errors, not style
  warnings; pin to ludeeus/action-shellcheck@2.0.0 (not @master)
- Rename workflow to 'Security Audit' (CodeQL is no longer included)
---
 .github/workflows/codeql.yml | 74 ++++++++++++------------------------
 1 file changed, 24 insertions(+), 50 deletions(-)

diff --git a/.github/workflows/codeql.yml b/.github/workflows/codeql.yml
index 4d1c19d..9a08ae4 100644
--- a/.github/workflows/codeql.yml
+++ b/.github/workflows/codeql.yml
@@ -1,4 +1,4 @@
-name: "CodeQL & Security Audit"
+name: "Security Audit"
 
 on:
   push:
@@ -10,55 +10,34 @@ on:
     - cron: "0 8 * * 1"
 
 jobs:
-  # ── CodeQL analysis ──────────────────────────────────────────────────────────
-  codeql:
-    name: CodeQL
-    runs-on: ubuntu-latest
-    permissions:
-      actions: read
-      contents: read
-      security-events: write
-
-    strategy:
-      fail-fast: false
-      matrix:
-        language: ["javascript-typescript"]
-        # Rust is not yet supported by CodeQL; covered by cargo-audit below.
-
-    steps:
-      - name: Checkout repository
-        uses: actions/checkout@v4
-
-      - name: Initialize CodeQL
-        uses: github/codeql-action/init@v3
-        with:
-          languages: ${{ matrix.language }}
-          queries: security-extended,security-and-quality
-
-      - name: Autobuild
-        uses: github/codeql-action/autobuild@v3
-
-      - name: Perform CodeQL Analysis
-        uses: github/codeql-action/analyze@v3
-        with:
-          category: "/language:${{ matrix.language }}"
-
-  # ── Rust security audit (cargo-audit) ────────────────────────────────────────
+  # ── Rust dependency audit (cargo-audit) ──────────────────────────────────────
+  # Skipped automatically when no Cargo.toml is present at repo root.
   rust-audit:
     name: Rust Security Audit
     runs-on: ubuntu-latest
     permissions:
       contents: read
-      security-events: write
 
     steps:
       - name: Checkout repository
         uses: actions/checkout@v4
 
+      - name: Check for Cargo.toml
+        id: has_cargo
+        run: |
+          if [ -f Cargo.toml ]; then
+            echo "present=true" >> "$GITHUB_OUTPUT"
+          else
+            echo "present=false" >> "$GITHUB_OUTPUT"
+            echo "No Cargo.toml found — skipping Rust audit"
+          fi
+
       - name: Install Rust stable
+        if: steps.has_cargo.outputs.present == 'true'
         uses: dtolnay/rust-toolchain@stable
 
       - name: Cache cargo registry
+        if: steps.has_cargo.outputs.present == 'true'
         uses: actions/cache@v4
         with:
           path: |
@@ -66,33 +45,28 @@ jobs:
             ~/.cargo/git
           key: ${{ runner.os }}-cargo-audit-${{ hashFiles('**/Cargo.lock') }}
 
-      - name: Install cargo-audit
-        run: cargo install cargo-audit --locked
-
-      - name: Run cargo audit
-        # --deny warnings treats advisories as errors so the job fails on CVEs
+      - name: Install and run cargo-audit
+        if: steps.has_cargo.outputs.present == 'true'
         run: |
-          if [ -f Cargo.toml ]; then
-            cargo audit --deny warnings
-          else
-            echo "No Cargo.toml at repo root — skipping rust audit"
-          fi
+          cargo install cargo-audit --locked
+          cargo audit --deny warnings
 
-  # ── Shell script lint (ShellCheck) ───────────────────────────────────────────
+  # ── Shell script security lint (ShellCheck) ───────────────────────────────────
+  # Fails only on errors (SC severity ≥ error). Warnings are reported but
+  # do not block the build — keeping CI signal meaningful.
   shellcheck:
     name: ShellCheck
     runs-on: ubuntu-latest
     permissions:
       contents: read
-      security-events: write
 
     steps:
       - name: Checkout repository
         uses: actions/checkout@v4
 
       - name: Run ShellCheck
-        uses: ludeeus/action-shellcheck@master
+        uses: ludeeus/action-shellcheck@2.0.0
         with:
-          severity: warning
+          severity: error
           scandir: "."
           ignore_paths: ".git"