NixReaperandClaude Sonnet 5
64169c4aee
CI / lint (push) Canceled after 0s
CI / typecheck (push) Canceled after 0s
CI / unit-tests (push) Canceled after 0s
CI / integration-tests (push) Canceled after 0s
CI / container-build (push) Canceled after 0s
CI / dependency-audit (push) Canceled after 0s
tests/integration/factories.py:make_provider did a raw INSERT assuming no "tmdb" Provider row existed yet. That held as long as every test used the db_session fixture's isolated, rolled-back transaction -- but the new ingestion-cascade tests call get_or_create_ingestion_job, which really commits via session_scope()'s own connection, outside that per-test isolation. Once that ran, every later test using the raw-insert factory hit "duplicate key value violates unique constraint uq_providers_slug". Fixed by using the app's own get_or_create_provider in the factory instead of a bare insert, which is also just correct: provider slugs are unique in production too, so the test helper should behave the same way real ingestion code does rather than assume a pristine table. Co-Authored-By: Claude Sonnet 5 <[email protected]>
84 lines
2.6 KiB
Python
84 lines
2.6 KiB
Python
"""Minimal data builders for integration tests — inserts ORM rows directly
|
|
so tests don't depend on network calls to a real provider."""
|
|
|
|
from __future__ import annotations
|
|
|
|
from sqlalchemy.ext.asyncio import AsyncSession
|
|
|
|
from app.core.ids import aurora_id
|
|
from app.models.artwork import Artwork
|
|
from app.models.credit import Credit
|
|
from app.models.enums import ArtworkType, MovieStatus
|
|
from app.models.external_id import ExternalID
|
|
from app.models.genre import Genre, MovieGenre
|
|
from app.models.movie import Movie
|
|
from app.models.person import Person
|
|
from app.models.provider import Provider
|
|
from app.repositories.provider_repository import get_or_create_provider
|
|
|
|
|
|
async def make_provider(session: AsyncSession, slug: str = "tmdb") -> Provider:
|
|
# get_or_create, not a raw insert: some tests (e.g. the ingestion
|
|
# cascade ones) create a real "tmdb" Provider row via session_scope()'s
|
|
# own connection, outside this test's rolled-back transaction, so it
|
|
# can already exist here regardless of db_session's per-test isolation.
|
|
return await get_or_create_provider(session, slug, slug.upper())
|
|
|
|
|
|
async def make_movie(
|
|
session: AsyncSession, *, title: str = "The Matrix", provider: Provider | None = None
|
|
) -> Movie:
|
|
movie = Movie(
|
|
title=title,
|
|
sort_title=title,
|
|
overview="A hacker discovers reality is a simulation.",
|
|
status=MovieStatus.RELEASED,
|
|
runtime_minutes=136,
|
|
)
|
|
session.add(movie)
|
|
await session.flush()
|
|
|
|
genre = Genre(name="Science Fiction", slug="science-fiction")
|
|
session.add(genre)
|
|
await session.flush()
|
|
session.add(MovieGenre(movie_id=movie.id, genre_id=genre.id))
|
|
|
|
person = Person(name="Keanu Reeves")
|
|
session.add(person)
|
|
await session.flush()
|
|
session.add(
|
|
Credit(
|
|
person_id=person.id,
|
|
entity_type="movie",
|
|
entity_id=movie.id,
|
|
department="Acting",
|
|
character="Neo",
|
|
billing_order=0,
|
|
)
|
|
)
|
|
|
|
session.add(
|
|
Artwork(
|
|
entity_type="movie",
|
|
entity_id=movie.id,
|
|
artwork_type=ArtworkType.POSTER,
|
|
provider_id=(provider or await make_provider(session)).id,
|
|
original_url="https://image.tmdb.org/t/p/original/poster.jpg",
|
|
is_primary=True,
|
|
)
|
|
)
|
|
|
|
if provider is not None:
|
|
session.add(
|
|
ExternalID(
|
|
entity_type="movie", entity_id=movie.id, provider_id=provider.id, external_id="603"
|
|
)
|
|
)
|
|
|
|
await session.flush()
|
|
return movie
|
|
|
|
|
|
def movie_aurora_id(movie: Movie) -> str:
|
|
return aurora_id("movie", str(movie.id))
|